Update NTP servers variable if chronyc returns success #4080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NTPSERVERS` variable should be updated only if `chronyc` returns success. This behavior gurantees, that in case of failure NTP servers update will be repeated shortly and we won't stay with blank NTP servers list. Signed-off-by: Roman Penyaev <r.peniaev@gmail.com> Reported-by: Renê de Souza Pinto <rene@renesp.com.br>
…30sec There is no good reason to delay NTP server update to 5 minutes, let's make cycles shorter and set 30 seconds. Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
rouming
force-pushed
the
ntpservers-update-on-success
branch
from
fa1405c
to
da9be14
Compare
rene
approved these changes
Jul 11, 2024
so I guess, it needs #4079 first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
update NTP servers in case of success only
NTPSERVERSvariable should be updated only ifchronycreturnssuccess. This behavior gurantees, that in case of failure NTP servers
update will be repeated shortly and we won't stay with blank
NTP servers list.
reduce NTP servers update delay from 5min to 30sec
There is no good reason to delay NTP server update to 5
minutes, let's make cycles shorter and set 30 seconds.
CC: @rene